Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security software can flag domain used in our proxy DNS lookup #6821

Closed
5 tasks done
KennethBates opened this issue Apr 8, 2021 · 3 comments · Fixed by OctopusDeploy/Calamari#714
Closed
5 tasks done

Security software can flag domain used in our proxy DNS lookup #6821

KennethBates opened this issue Apr 8, 2021 · 3 comments · Fixed by OctopusDeploy/Calamari#714
Assignees
@johnsimons
Labels
area/core kind/bug This issue represents a verified problem we are committed to solving

Comments

@KennethBates
Copy link

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

Octopus uses an obscure URL to look up the registry for the proxy configured to that domain. This is intentional since a real well-known URL would likely be on someone's exclusion list. The problem is this URL (http://test9c7b575efb72442c85f706ef1d64afa6.com) is being flagged by security software as potentially domain generated algorithm. We should change this domain to something that does not look like [guid].com.

Links

Reported here: https://octopus.zendesk.com/agent/tickets/67262
@KennethBates KennethBates added the kind/bug This issue represents a verified problem we are committed to solving label Apr 8, 2021
@mcasperson
Copy link

Potentially unsafe proxy DNS lookup

johnsimons pushed a commit to OctopusDeploy/Calamari that referenced this issue Apr 9, 2021
Don't use a guid for the domain name
ff55fa9 
This can cause security software to flag as potentially domain generated algorithm

Fixes OctopusDeploy/Issues#6821
@johnsimons johnsimons mentioned this issue Apr 9, 2021
Merged
@octoreleasebot
Copy link

Release Note: Url used for proxy testing is now using a proper domain name

@Octobob
Copy link
Member

Octobob commented Aug 11, 2021 •
edited

🎉 The fix for this issue has been released in:

Release stream Release
2021.2 2021.2.1674
2021.3+ all releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnsimons johnsimons

Labels
area/core kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use a guid for the domain name OctopusDeploy/Calamari
6 participants
@johnsimons @mcasperson @Octobob @octoreleasebot @KennethBates @kengel100